fix(jobscheduler): stop scheduling new jobs on shutdown#365
Merged
Conversation
The scheduler's context is decoupled from SIGTERM so workers can finish in-flight jobs during the HTTP drain window, but this meant new jobs and periodic re-arms kept being scheduled throughout shutdown. Add a Drain phase that halts new submissions and periodic re-arming as soon as shutdown begins, while leaving workers running until the context is cancelled for the final teardown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduler's context is decoupled from SIGTERM so workers can finish
in-flight jobs during the HTTP drain window, but this meant new jobs and
periodic re-arms kept being scheduled throughout shutdown.
Add a Drain phase that halts new submissions and periodic re-arming as
soon as shutdown begins, while leaving workers running until the context
is cancelled for the final teardown.